[RNMobile] Remove error banners from native media&text and audio blocks #39694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
Mobile App - i.e. Android or iOS
|
Size Change: +299 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
mchowning
force-pushed
the
rnmobile/fix/remove-error-banners
branch
from
1523efb to
c8de7a9
Compare
SiobhyB
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
I tested on both iOS and Android emulators. In my testing, I can confirm everything looked good after uploading via a device while offline on both platforms, the redundant message is gone and the main message remains. Yay for less clutter 🎉
I also tested other flows for adding audio, including "add from URL", and couldn't find any unintentional regressions.
As this is a user-facing change, perhaps it should be noted in the changelog too?
Going ahead to approve this PR, thanks Matt! 🙌
|
Thanks for the review @SiobhyB ! 🙇
Good point. I made that update. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes wordpress-mobile/gutenberg-mobile#4247 by removing the error banner that appeared at the top of the screen when an upload failed on native in the Media&Text or Audio blocks.
Why?
The error information is already contained within the block itself and WPAndroid also sends a second error banner already.
How?
Removing the calls to
createErrorNotice.Testing Instructions
Perform the following with both the (1) Audio and (2) Media&Text blocks:
Note that WPiOS does not display the bottom banner shown in the screenshots.